-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field Slip system test adjustments #2141
Conversation
…"login!" issues Use identifiers like the ones in object_link_helper to facilitate finding elements in the field slip test (avoiding xpaths)
Update: This PR does have some things we may want to keep:
|
@mo-nathan — I just converted your original short system tests to equally short integration tests, as we discussed a couple weeks ago. I think keeping the tests separate preserves your original intent. Note the addition of selector classes to the templates, so we don't have to use XPATH selectors in our tests - much easier. |
@mo-nathan I am realizing this will affect your #2160 Field Slip Forms PR. I believe it is an improvement on the form HTML, particularly the selectors, and makes the tests less brittle. If you like, I'll be happy to check #2160 over and reconcile these changes with that PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Ok thanks, I will merge. Just say the word and I'll either reconcile it with #2160, or offer suggestions - I realize this creates extra work on a long-running PR of yours and that you're probably not wanting any added confusion with it. |
Refactors the
field_slips_test
as integration tests. Should run faster and be just as effective.Background:
With system tests, they're slow and we only really need them if we're testing JS.