New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor display fix for comments #2144

Merged

nimmolo merged 2 commits into main from nimmo-actioncable

May 18, 2024

Contributor

nimmolo commented May 17, 2024

This just puts the .none-yet message at the end (when hidden) so that the borders of the comments are not doubled on top.

nimmolo added 2 commits

May 15, 2024 22:42


          Update observation_comment_system_test.rb

f8a7e8a


          Update _comments_for_object.erb

3f7af17

Move none-yet to the end of the comments, so that the :first-child selector works as expected

nimmolo marked this pull request as ready for review

May 17, 2024 00:58

Collaborator

coveralls commented May 17, 2024 •

edited

Loading

coverage: 94.434%. remained the same
when pulling 3f7af17 on nimmo-actioncable
into dee801a on main.

nimmolo merged commit 15ec8fb into main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet