Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompleters: CSS and helper refactor #2186

Merged
merged 13 commits into from
Jun 21, 2024
Merged

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Jun 20, 2024

  • Alter autocompleters to use Bootstrap "dropdown" CSS classes where possible. (Requires changing autocompleter item markup from simple <li>Option</li> to <li><a href="#">Option</a></li>, but we get hover and click events for free, and easier BS upgrades.)
  • Change the arg for "autocompleter query type" in autocompleter_field helper from autocomplete: to type:.
  • Stimulus housekeeping: Change the root element of an autocompleter controller from the input (whose sibling is the .auto_complete list) to the parent element for both.
  • Better functionality for swapping the autocompleter type (to be used for new "locations_containing" lat/lng)
  • New working "Region" autocompleter, for "Help Identify"

There should be nearly no change in appearance or function, otherwise.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.45%. remained the same
when pulling ef1d797 on autocompleters-refactor-js
into bc2ed6f on main.

This means the wrapping element MUST have class `.dropdown`. Ideally the controller would be on the wrapping element, but we have a special case that makes that impractical.
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.45%. remained the same
when pulling 8d567a1 on autocompleters-refactor-js
into bc2ed6f on main.

@nimmolo nimmolo marked this pull request as ready for review June 21, 2024 01:26
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.45%. remained the same
when pulling ce73d93 on autocompleters-refactor-js
into bc2ed6f on main.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.407% (-0.04%) from 94.45%
when pulling c709ed9 on autocompleters-refactor-js
into bc2ed6f on main.

@nimmolo nimmolo merged commit ec173c0 into main Jun 21, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants