Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompleters: CSS and helper refactor #2186

Merged
merged 13 commits into from
Jun 21, 2024
Merged

Autocompleters: CSS and helper refactor #2186

merged 13 commits into from
Jun 21, 2024

Commits on Jun 19, 2024

  1. Update autocompleter_controller.js

    @nimmolo
    nimmolo committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    87d7888 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into autocompleters-refactor-js

    @nimmolo
    nimmolo committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3cd145d View commit details
    Browse the repository at this point in the history

  3. Convert dropdown to use links

    @nimmolo
    nimmolo committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c2cb592 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Update BlackOnWhite.scss

    @nimmolo
    nimmolo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a8f2d9b View commit details
    Browse the repository at this point in the history

  2. Add .position-relative to autocomplete form group

    @nimmolo
    nimmolo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2c2aa00 View commit details
    Browse the repository at this point in the history

  3. Use bootstrap classes for dropdown div, li, add nested <a> 

    add click handlers for the <a>
.selected -> BS .active class
    @nimmolo
    nimmolo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fabf13c View commit details
    Browse the repository at this point in the history

  4. autocompleter_field helper: Rename arg from "autocomplete" to "type"

    @nimmolo
    nimmolo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    416005e View commit details
    Browse the repository at this point in the history

  5. Remove mouseover highlighting 

    We now get it for free by using <li><a> for items
    @nimmolo
    nimmolo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ef1d797 View commit details
    Browse the repository at this point in the history

  6. Go ahead and use .dropdown for easier debugging 

    This means the wrapping element MUST have class `.dropdown`. Ideally the controller would be on the wrapping element, but we have a special case that makes that impractical.
    @nimmolo
    nimmolo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8d567a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Better comments, this.WRAP_CLASS

    @nimmolo
    nimmolo committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6b8405e View commit details
    Browse the repository at this point in the history

  2. Restore swap detail

    @nimmolo
    nimmolo committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ce73d93 View commit details
    Browse the repository at this point in the history

  3. Go ahead and put the stimulus controller scope on the form-group

    @nimmolo
    nimmolo committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    12fe138 View commit details
    Browse the repository at this point in the history

  4. Fix identify filter swapping, add new working "region" autocompleter

    @nimmolo
    nimmolo committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c709ed9 View commit details
    Browse the repository at this point in the history