New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4KiB hard-coded buffer limits #51
Comments
Hello @mxjeff |
cataldor
added a commit
to cataldor/libmpdclient
that referenced
this issue
Mar 27, 2020
Allow the internal buffer of libmpdclient to grow dynamically in size as needed by mpd_{async/sync}_send_command. Previously, the buffer was limited to 4KiB. Address issue reported downstream by Debian[1] and upstream by kaliko (@mxjeff)[2] [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953110 [2] MusicPlayerDaemon#51
cataldor
added a commit
to cataldor/libmpdclient
that referenced
this issue
Mar 27, 2020
Identify messages that are over the 4KiB buffer limit Address issue reported downstream by Debian[1] and upstream by kaliko (@mxjeff)[2] [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953110 [2] MusicPlayerDaemon#51
MaxKellermann
pushed a commit
that referenced
this issue
Jul 3, 2020
Identify messages that are over the 4KiB buffer limit Address issue reported downstream by Debian[1] and upstream by kaliko (@mxjeff)[2] [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953110 [2] #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is a follow-up of debian bug report #953110 :
Reproducer:
Uses mpc to send a 'find' request, containing an invalid search expression. The expected result is an error message about the invalid search expression.
working:
Note the request size on line 3: 4096 bytes.
broken:
The only difference is one more '+' in the expression, which would result in a request of 4097 bytes.
Instead of error about the invalid request, a timeout occurs after 30 seconds because the request is not really sent (note the missing
sendto()
call).Ideally, libmpdclient should support requests of arbitrary size (eventually reaching the server limit), but if that is not feasible, at least a proper error reporting would be nice.
src: https://bugs.debian.org/953110
The text was updated successfully, but these errors were encountered: