Remove negative margin from Artist and Genre-page header-images #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy request for musish pending review. Review with commit 38ccdf9 |
raphaelvigee
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the negative margin and give header-images the same offset from the scrollbar as the other page-content-elements have.
Negative margins on header-images on the artist-page and genre-page caused a permanent (could not be removed by enlarging container) and unnecessary vertical scrollbar to appear on the page.
This bug was introduced with my recent PR implementing custom scrollbars.
I assume the negative margin was initially applied to enlarge the header-images, but I don't think it is necessary any longer.