Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain and channel monitors #36

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Add chain and channel monitors #36

merged 4 commits into from
Nov 8, 2022

Conversation

TonyGiorgio
Copy link
Contributor

No description provided.

benthecarman
benthecarman reviewed Nov 8, 2022
View reviewed changes
node-manager/src/nodemanager.rs Outdated Show resolved Hide resolved
node-manager/src/wallet.rs Outdated Show resolved Hide resolved
@benthecarman
Copy link
Collaborator

pr title says channel monitor too but i dont see one

@benthecarman benthecarman mentioned this pull request Nov 8, 2022
Merged
futurepaul
futurepaul requested changes Nov 8, 2022
View reviewed changes
node-manager/src/node.rs Show resolved Hide resolved
node-manager/src/nodemanager.rs Show resolved Hide resolved
@TonyGiorgio TonyGiorgio mentioned this pull request Nov 8, 2022
Closed
@TonyGiorgio
Copy link
Contributor Author

Handled what I could/should here, let me know if it's good to go.

futurepaul
futurepaul approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay cool good call on doing errors in a separate pr

@benthecarman
Copy link
Collaborator

needs rebase

TonyGiorgio and others added 3 commits November 8, 2022 13:47
@TonyGiorgio
Add chain and channel monitors
e5b32b2
@TonyGiorgio @benthecarman
Update node-manager/src/wallet.rs
838093c 
Co-authored-by: benthecarman <15256660+benthecarman@users.noreply.github.com>
@TonyGiorgio
Fix clone issue
0162c96
@TonyGiorgio TonyGiorgio merged commit 304a9c4 into master Nov 8, 2022
@TonyGiorgio TonyGiorgio deleted the more-monitors branch November 8, 2022 19:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futurepaul futurepaul futurepaul approved these changes

@benthecarman benthecarman benthecarman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TonyGiorgio @benthecarman @futurepaul