Update Red Apple Rag to 2.16 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Voices reorganized in variables, added lilypond fingerings and an optional TabStaff (commented).
wchargin
referenced
this pull request
in wchargin/MutopiaProject
Jul 14, 2018
Summary: We can add this script only now, because the first movement has been completed. Similarly, we will only be able to add checking for each later movement once it has also been completed. Test Plan: Running `./assert_consistent_marks.sh` or `make quickcheck` passes as is, but if a `\barNumberCheck #1` is changed to `\barNumberCheck MutopiaProject#2`, then these invocations fail with one “missing” message and one “superfluous” message, as desired.
wchargin
referenced
this pull request
in wchargin/MutopiaProject
Jul 19, 2018
Summary: We can add this script only now, because the first movement has been completed. Similarly, we will only be able to add checking for each later movement once it has also been completed. Test Plan: Running `./assert_consistent_marks.sh` or `make quickcheck` passes as is, but if a `\barNumberCheck #1` is changed to `\barNumberCheck MutopiaProject#2`, then these invocations fail with one “missing” message and one “superfluous” message, as desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added bar checks, midiInstrument and unfolded repeats in midi.
And I've improved the style of lilypond code, following best practices (two space indentation, duration speficied at the beginning of each bar, etc.).