Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MvvmCross.StarterPack #1658

Closed
wants to merge 12 commits into from
Closed

Improve MvvmCross.StarterPack #1658

wants to merge 12 commits into from

Conversation

heytherewill
Copy link
Contributor

Still WIP

@heytherewill heytherewill mentioned this pull request Mar 26, 2017
11 tasks
@martijn00 martijn00 mentioned this pull request Apr 14, 2017
22 tasks
@martijn00
Copy link
Contributor

How's this going? :) We would love to add this to the release of MvvmCross 5.0 in about two weeks.

@nmilcoff
Copy link
Contributor

I think the iOS View file should reflect the changes from the new MvxIosViewPresenter: MainView should have a MvxRootPresentationAttribute (like this)

@heytherewill
Copy link
Contributor Author

@martijn00 I'll need someone with a Windows machine to help me with the WPF Views. The rest I can complete early next week, so this can most likely enter the release :)

@nmilcoff That's all that I need to change? if so, consider it done :)

@nmilcoff
Copy link
Contributor

@WillsB if there is only one view then yes, that's all :)

@martijn00
Copy link
Contributor

How's this going? @WillsB

@heytherewill
Copy link
Contributor Author

@martijn00 According to this blog post, the new contentFiles feature requires project.json, so the multi-language support will have to wait until we migrate to netstandard (which, according to the Roadmap, will only happen for 6.0). I'll close this PR (because it has too many changes that'll only be useful in the future) and open a new one containing only the essential stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants