Update ContentFiles Referenced In Readme.txt To Use MVVMCross 6.x Namespaces (& Remove MvxTrace References) #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Revert Setup.cs.pp changes that I'm not sure about Fix Extra Spaces & Alignment Sort Usings
martijn00
approved these changes
Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is my first time submitting a pull request to an open source project on GitHub, I'm used to using VSTS with TFVC. Hopefully this is done right (forking the project, making changes and then sending a pull request).
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Documentation Update I think (considering these are referred to as sample files in the readme.txt, but are NuGet ContentFiles in reality, but not sure if they're still used as ContentFiles, since readme.txt also says no content files will be installed).
When you start a new MVVMCross 6.x project and the readme.txt file appears, there's a link to sample files (https://github.com/MvvmCross/MvvmCross/blob/develop/ContentFiles/) - however these files are out of date because they don't use the new MVVMCross 6.x namespaces. They also include references to MvxTrace, which is deleted in 6.x
🆕 What is the new behavior (if this is a feature change)?
The namespaces are now updated to use the new MVVMCross 6.x namespaces. The references to MvxTrace are also deleted.
💥 Does this PR introduce a breaking change?
Not if you're using MVVMCross 6.x (since this updates these files to match the MVVMCross 6.x documentation)
🐛 Recommendations for testing
Copying and pasting these files into real MVVMCross projects and ensuring the namespaces all are found correctly.
One other thing to note: I think other changes will need to be made to these files with all the changes to Setup etc. that is shipping in MVVMCross 6.x, but I don't know enough about those changes yet to confidently update these files, so I'll just provide what I am confident with (namespace changes and obvious deletions)
📝 Links to relevant issues/docs
🤔 Checklist before submitting