Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android NumberPicker binding documentation #3257

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Android NumberPicker binding documentation #3257

merged 2 commits into from
Jan 15, 2019

Conversation

tbalcom
Copy link
Contributor

@tbalcom tbalcom commented Jan 14, 2019

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Docs update

⤵️ What is the current behavior?

The recently added Android.Widget.NumberPicker bindings are not yet documented.

🆕 What is the new behavior (if this is a feature change)?

Adds documentation for the recently added Android.Widget.NumberPicker Value and DisplayedValues bindings.

I added a Notes column to the table because the order of the bindings are important; if Value is declared before DisplayedValues then the NumberPicker will always start at 0. This happens because the default value of NumberPicker.Max starts at 0. When the Value binding is declared first then NumberPicker.SetValue() is being called before NumberPicker.Max has been set. I can't think of any reasonable way around this.

I also fixed a minor bug in the MvvmCross.Droid.Support.V7.Preference table which was missing a column header for the Mvx version introduced column.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

N/A

📝 Links to relevant issues/docs

N/A

🤔 Checklist before submitting

@Cheesebaron Cheesebaron merged commit 24ad25b into MvvmCross:develop Jan 15, 2019
@martijn00 martijn00 added this to the 6.2.3 milestone Jan 15, 2019
@Cheesebaron Cheesebaron added the t/docs Documentation type label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/docs Documentation type
Development

Successfully merging this pull request may close these issues.

3 participants