Android NumberPicker binding documentation #3257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Docs update
The recently added Android.Widget.NumberPicker bindings are not yet documented.
🆕 What is the new behavior (if this is a feature change)?
Adds documentation for the recently added Android.Widget.NumberPicker
Value
andDisplayedValues
bindings.I added a Notes column to the table because the order of the bindings are important; if
Value
is declared beforeDisplayedValues
then the NumberPicker will always start at 0. This happens because the default value ofNumberPicker.Max
starts at 0. When theValue
binding is declared first thenNumberPicker.SetValue()
is being called beforeNumberPicker.Max
has been set. I can't think of any reasonable way around this.I also fixed a minor bug in the MvvmCross.Droid.Support.V7.Preference table which was missing a column header for the Mvx version introduced column.
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
N/A
📝 Links to relevant issues/docs
N/A
🤔 Checklist before submitting