Fixed the MvxSimpleTableViewSource; now can work with both storyboard and xib-cells #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MvvmCross#2897, since it blocks the standard constructor which was already there. The two constructors now virtually did the same. Added a boolean to the second constructor, so you can actually set whether or not you want to register the nib cell for reuse, where true is the current value (and thus the standard) and false can be used if you use storyboard nibs.
|
|
martijn00
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the extra constructor for the MvxSimpleTableViewSource added in #2897, since it blocks the standard constructor which was already there. The two constructors now virtually did the same. The functionality added in 2897 was broken again in #3175.
Added a boolean to the second constructor, so you can actually set whether or not you want to register the nib cell for reuse, where true is the current value (and thus the standard) and false can be used if you use storyboard nibs.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
In 2897 we added functionality to use SB cells instead of just xib-cells. This was broken again in 3175, because for the SB views we do not need to register the nib for cell reuse. So I removed the first constructor and added the boolean to the standard constructor which was already there before 2897. Doing this I virtually revert 3175 and implemented 2897 in a way which is non-blocking for the standard xib files.
The SB view-cells will not work at this moment, they can not be found when we dequeue the cells.
🆕 What is the new behavior (if this is a feature change)?
The SB views will work correctly again, if you add the bool false to the constructor for the MvxSimpleTableViewSource
💥 Does this PR introduce a breaking change?
It does not, although it can break functionality which depends on 2897, but that is already broken in mvvmcross 6.2.3 because of 3175.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting