Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Added And and Or operators #22

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

Olyno
Copy link
Contributor

@Olyno Olyno commented Jul 29, 2020

This pull request includes the && and || operators for the boolean expression.

Related to:

@Syst3ms
Copy link
Contributor

Syst3ms commented Jul 30, 2020

This will only be merged depending on the outcome of the discussion at #23.

@Mwexim
Copy link
Owner

Mwexim commented Aug 14, 2020

Just looked at #8. It has this weird syntax for default values (object || object).

I think it should be removed there because it's ridiculous and offers no real advantages, but if it stays there make sure to change the priority on this one to be higher.

Copy link
Contributor

@Syst3ms Syst3ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to approve this change due to not finding any satisfactory solution to the problem posed in #23. It's not the most elegant, but at least the syntax comes from somewhere.

@Olyno Olyno merged commit e0f4284 into Mwexim:master Sep 2, 2020
@Olyno Olyno deleted the feature/addOperatorsAndOr branch September 2, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants