Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Javascript to update visible alert counts makes assumptions it shouldn't #349

Closed
lairdshaw opened this issue Mar 28, 2024 · 0 comments · Fixed by #350
Closed

The Javascript to update visible alert counts makes assumptions it shouldn't #349

lairdshaw opened this issue Mar 28, 2024 · 0 comments · Fixed by #350

Comments

@lairdshaw
Copy link
Contributor

In particular, it assumes that an element .alerts a exists, when it might not if the myalerts_headericon template has been customised. This can cause Javascript errors to halt AJAX functions.
lairdshaw added a commit to lairdshaw/MyAlerts that referenced this issue Mar 28, 2024
@lairdshaw
Fix MyBBStuff#349: Assumptions in the JS to update visible alert counts
72065a9 
Fixes MyBBStuff#349
@lairdshaw lairdshaw mentioned this issue Mar 28, 2024
Merged
lairdshaw added a commit that referenced this issue Apr 13, 2024
@lairdshaw
Merge pull request #350 from lairdshaw/fix-349
b9276a7 
Fix #349: Assumptions in the JS to update visible alert counts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #349: Assumptions in the JS to update visible alert counts lairdshaw/MyAlerts
1 participant
@lairdshaw