Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-table layouts break client-side updating #356

Closed
lairdshaw opened this issue Apr 13, 2024 · 0 comments · Fixed by #357
Closed

Non-table layouts break client-side updating #356

lairdshaw opened this issue Apr 13, 2024 · 0 comments · Fixed by #357

Comments

@lairdshaw
Copy link
Contributor

The client-side updating Javascript relies on table elements in which aren't necessarily present in customised templates, especially those templates which have been customised for a responsive design which doesn't use tables. We should instead rely on id and class attributes.
lairdshaw added a commit to lairdshaw/MyAlerts that referenced this issue Apr 13, 2024
@lairdshaw
Fix MyBBStuff#356: Non-table layouts break client-side updating
11a68e2 
Fixes MyBBStuff#356.
@lairdshaw lairdshaw mentioned this issue Apr 13, 2024
Merged
lairdshaw added a commit that referenced this issue Apr 17, 2024
@lairdshaw
Merge pull request #357 from lairdshaw/fix-356
37f320a 
Fix #356: Non-table layouts break client-side updating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #356: Non-table layouts break client-side updating lairdshaw/MyAlerts
1 participant
@lairdshaw