Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthersocialNetwork (ESN) support added #1881

Merged
merged 2 commits into from
Jun 25, 2018

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Jun 1, 2018

@coveralls
Copy link

coveralls commented Jun 1, 2018

Coverage Status

Coverage increased (+0.008%) to 55.21% when pulling 9fbd026 on OpenCommunityCoin:esn-support into a297eb7 on MyCryptoHQ:develop.

@hackmod
Copy link
Contributor Author

hackmod commented Jun 14, 2018

rebased

},
ESN: {
id: 'ESN',
name: 'EthersocialNetwork',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to just call this "Ethersocial", because we append "network" to a lot of networks. It would often read as "EthersocialNetwork network". If you're fine with that though, no problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem~
there are some fork coin exists named "ETSC" (ethereum social coin)
and some people in Korea confused on it. so we use officially EthersocialNetwork to be clear.

Copy link

@ghost ghost Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackmod Our full name is Ethereum Social BTW 😅

wbobeirne
wbobeirne previously approved these changes Jun 14, 2018
Copy link
Contributor

@wbobeirne wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming this all looks good, loaded fine 👍

@hackmod
Copy link
Contributor Author

hackmod commented Jun 18, 2018

rebased

@dternyak
Copy link
Contributor

@hackmod Looks like a recent merge has caused a few conflicts. Do you mind rebasing?

@hackmod
Copy link
Contributor Author

hackmod commented Jun 20, 2018

@dternyak // no problem! rebased.

hackmod added a commit to OpenCommunityCoin/MyCrypto that referenced this pull request Jun 20, 2018
@dternyak
Copy link
Contributor

@hackmod Thanks! It looks like you've got some failing tests, can you take a look at those as well?

hackmod added a commit to OpenCommunityCoin/MyCrypto that referenced this pull request Jun 20, 2018
hackmod added a commit to OpenCommunityCoin/MyCrypto that referenced this pull request Jun 20, 2018
@hackmod
Copy link
Contributor Author

hackmod commented Jun 20, 2018

@dternyak // it looks like travis-ci bug or somthing. (simply git commit --amend and git push -f again)
fixed now (6/24)

@ghost
Copy link

ghost commented Jun 21, 2018

Ethersocial Network is a scam!!! DO NOT MERGE THIS PR!!!!!!

@hackmod
Copy link
Contributor Author

hackmod commented Jun 21, 2018

image

@dternyak
Do not feed the troll, he is well known serial hard forker in Korea.

Ethersocial Network is born at the biggest miner/cryptocurrency community in Korea https://www.ddengle.com/

@ghost
Copy link

ghost commented Jun 22, 2018

default
2

LOL You guys said you will list ESN on Bit-Z several months ago.... now there is nothing 😆

@hackmod
Copy link
Contributor Author

hackmod commented Jun 22, 2018

do not use fake image
this is the original post written in Korean https://www.ddengle.com/esn/7837146

@ghost
Copy link

ghost commented Jun 22, 2018

@hackmod LOL only time will & would tell. There is no such coin that takes like 2 months for listing on a single exchange unless you guys are lying.... ddengle P2P thread is the worst case ddengle will end up for buying & selling their coin themselves 😃

@ghost
Copy link

ghost commented Jun 22, 2018

@magnalucus @kimmyeonghun Why don't you guys compensate your presale ethereum funds to Youbit hack victims??

@wbobeirne
Copy link
Contributor

Hey guys, I'm going to ask that you keep this kind of discussion somewhere else. Personal attacks and drama will not be tolerated on our GitHub. Any further comments of that nature will be removed.

Adding network support to MyCrypto is in no way an endorsement of any project, it's simply to provide users with a tool to interact with their preferred network.

@ghost
Copy link

ghost commented Jun 23, 2018

@wbobeirne Please close this PR, they are trying to impersonate Ethereum Social [ ETSC ] and they are telling so much rumors out of nowhere.

Proof they are trying to attempt illegal impersonation & spreading bad rumors of Ethereum Social)
a
b
c
d
e

Ethereum Social is the only coin that runs with normal blockchain development & professional development company located on Korea.

We run Ethereum Classic public node api endpoint service for faster connection, and some Callisto blockchain based projects with Ethereum Commonwealth.

EtherSocial Network is only composed of some volunteers with small payment and hired marketers for fishing miners on korea.

We don't need to support forked, scam coin for their localized scam for selling their premined coins,
It will only result as confusing ETSC and ESN for investors and users using the coin.

hackmod added a commit to OpenCommunityCoin/MyCrypto that referenced this pull request Jun 23, 2018
hackmod added a commit to OpenCommunityCoin/MyCrypto that referenced this pull request Jun 23, 2018
@wkpark
Copy link

wkpark commented Jun 23, 2018

hello. I am real @hackmod (you can checkout my real profile at github)
we do not wanted to make much noise for this PR at your nice project, sorry for inconvenience.

but to be clear, the following is updated current status of ESN and ETSC

EtherSocial Network (ESN) Ethereum Social (ETSC)
https://ethersocialnetwork.com http://ethereumsocial.kr/
White paper https://github.com/ethersocial/wiki/blob/master/pages/white-paper/%5Benglish%5D-white-paper.md FIXME (disappered)
Community support (Since 2013~ biggest and most popular blockchain/mining community in Korea) : https://www.ddengle.com FIXME
Devs : @h-s-o-o , @kimmyeonghun , @magnalucus (FIXME) // external developers @hackmod (me), @ComBba (sejun pool) @turbobit (gonspool) @freewinter (mobile wallet, topmining pool) @akx20000a , @bitminings (almost do nothing. owner of https://http://www.gazua.tv )
Source code release date (Jan 31, 2018) : https://github.com/ethersocial/go-esn (See also the attached image) a fork of the original ESN (Feb 9, 2018)
Network Hash rate : ~250GH/s (https://ethersocial.net/stats/hashrate ) ~5GH/s (https://explorer.ethereumsocial.kr/stats/hashrate )
no official pool site available // about ~7. https://esc.gonsmine.com/ https://esn.topmining.co.kr/ https://comining.io https://esn.solopool.org/ https://pool.ethereumsocial.kr (official) https://comining.io https://etsc.solopool.org/ http://etsc.altpool.pro
network state (peer explorer) : https://escstats.gonsmine.com https://stats.ethereumsocial.kr/
Feed back site : https://www.ddengle.com/esn http://www.gazua.tv/post/ho
Exchange : in progress (p2p price: ~3500 satoshi ) https://stocks.exchange/trade/ETSC/BTC (price ~10 satoshi)

image

currently, the genesis hash between ESN and ETSC are different

$ node check.js
...
Total ESN = 499224895.246414219
Total ETSC = 10055699039.79956214899999998

Total 417 accounts matched / 45 accounts not matched /  11 accounts ESN only
Total 2470 accounts ETSC only

@dternyak dternyak merged commit 1ab0d81 into MyCryptoHQ:develop Jun 25, 2018
@dternyak
Copy link
Contributor

dternyak commented Jun 25, 2018

As specified by our policies outlines on the wiki, support for third-party networks will be added as long as they abide by our existing policies.

Since EthersocialNetwork does, I'm merging this PR. We reserve the right to discontinue support for networks at any time, so should the integrity of any chain be compromised, we can take the correct action at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants