Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interact with contracts flow #2896

Merged
merged 55 commits into from
Dec 9, 2019
Merged

Interact with contracts flow #2896

merged 55 commits into from
Dec 9, 2019

Conversation

PeterZlodej
Copy link
Contributor

Closes #ISSUE_NUMBER_GOES_HERE

🎉 🎉 🎉

Description

......

Changes

  • High level
  • changes that
  • you made

Reusable Code/Components

Steps to Test

  1. Steps
  2. to
  3. test

Zeplin Design

Quality Assurance

  • The branch name is in lowercase-kebab-case with no prefix (unless it was created from Clubhouse)
  • The base branch is develop or gau (no nested branches)
  • This is related to a maximum of one Clubhouse story or GitHub issue
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types)
  • If code is copied from existing directories, there is an explanation of why this is necesary in the description/changes, and all copying is done in separate commits to make them easy to filter out

PeterZlodej and others added 30 commits October 29, 2019 08:10
@PeterZlodej
General steps layouts and routes setup
bb5c6b9
@PeterZlodej
Added network selector to interact step
63197c3
@PeterZlodej
Add contract selection and abi fields to form
0a6992d
@PeterZlodej
Contract selection logic
5369f02
@PeterZlodej
Use state factory for handling flow states
4669910
@PeterZlodej
Auto-select existing contract on address change
62291d8
@PeterZlodej
Created/updated contract & function dropdowns
6cba8d4
@PeterZlodej
Generate basic interaction form from the ABI
95801df
@PeterZlodej
Handle cases when input name is missing
1fa056b
@PeterZlodej
Handle interaction form submit
ae1be37
@PeterZlodej
Implemented read contract calls
1264090
@PeterZlodej
Added basic error messaging
7f9bb20
@PeterZlodej
Make dropdowns searchable
5262de4
@PeterZlodej
merge from master
81d704a
Merge branch 'interact-with-contracts-flow' of https://github.com/Pet…
5bc2706 
…erZlodej/MyCrypto into interact-with-contracts
Move SigningComponents to global types
29e59af
Initial implementation of write command for interacting with contracts
a973558
Update translations
5c017b6
@PeterZlodej
Updated styles for input/output fields
ea341ea
@PeterZlodej
Merge signing flow for write operations
f6c2876
@PeterZlodej
Updated generated form styles
8fad9bc
@PeterZlodej
Output bool field renamed
62ed9c4
Merge branch 'interact-with-contracts-flow' of https://github.com/Pet…
c78494c 
…erZlodej/MyCrypto into interact-with-contracts
@PeterZlodej
Created confirm interaction and receipt steps
e7343ab
@PeterZlodej
Added gas price, and limit fields to write
ede722d
@PeterZlodej
Added error messaging for write operation
8624a3e
@PeterZlodej
Add value field to payable functions
dde8176
@PeterZlodej
Use dropdown for inputing boolean values
e84baf1
Merge branch 'interact-with-contracts-flow' of https://github.com/Pet…
223697a 
…erZlodej/MyCrypto into interact-with-contracts
Use correct eth value, fix confirm screen data
c4773bc
Amadej Pevec and others added 25 commits November 25, 2019 13:10
Show correct asset in receipt step
be1a18c
Editable txConfig (price, limit, nonce) component
6ad2d20
@PeterZlodej
Handle errors in save/interact with contract
c4eab7b
Use checkbox for gas limit, show error when estimating gas
4f4eca0
@PeterZlodej
Merge branch 'interact-with-contracts' of https://github.com/amacar/M…
22ce3b6 
…yCrypto into interact-with-contracts-flow
@PeterZlodej
Update error messaging in gas limit calculation
66bbb2c
@amacar
Merge pull request MyCryptoHQ#119 from PeterZlodej/interact-with-cont…
6bf1f3f 
…racts-flow

Interact with contracts flow
Add support for buffer and arrays in contract interaction
9a8d1c2
@PeterZlodej
Added delete contract option
1aa8b10
Prefix addresses in returned array when interacting with contract MyC…
2a5acd5 
…ryptoHQ#2075
Prevent spamming 'interact' button
e3a625b
Merge branch 'master' of https://github.com/amacar/MyCrypto into inte…
6e8b06d 
…ract-with-contracts
Unify imports
6d082bd
@PeterZlodej
Remove hardcoded strings
12eac15
@PeterZlodej
Set font-size in em instead of px
1578296
Merge branch 'interact-with-contracts-flow' of https://github.com/Pet…
92505c5 
…erZlodej/MyCrypto into interact-with-contracts
Extract gas selector as separate component
1498f11
@PeterZlodej
Allow ETH domain to be entered instead of address
5cb9ac5
@PeterZlodej
Fetch contract ABI from etherscan
111c87e
@PeterZlodej
Shrink abi text area after clicking interact btn
d96fb07
@PeterZlodej
Pass network instead of networkId
6822052
@PeterZlodej
Fix textarea UX
c961a67
@PeterZlodej
Merge from master
70e3a4e
@PeterZlodej
Don't allow dropdowns to expand past the footer.
f701a02
@PeterZlodej
Merge from master
7bbd9be
@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@PeterZlodej PeterZlodej merged commit 7bbd9be into MyCryptoHQ:contracts-interaction-deep-link-prefill Dec 9, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 48.075% when pulling 7bbd9be on PeterZlodej:interact-with-contracts-flow into 5837a04 on MyCryptoHQ:contracts-interaction-deep-link-prefill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PeterZlodej @mycrypto-bot @coveralls @amacar