Throw on CryptoCompare API error #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbobeirne
added
the
status: ready for review
|
I'm inclined to wait until vlad updates CC backend as specified in MyEtherWallet/MyEtherWallet#462 and implement paged token requests. |
|
We'll definitely want to implement that, but this change handles any class of error from their API, not just this one. The current behavior is to very incorrectly end up with rates that are |
dternyak
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small bandaid for #462, CryptoCompare price error responses come back with valid json and a 200 status code so they were running through the rest of the code as though it were a success response. This caused an uncaught error to bubble up. This just throws if the API comes back with an error, causing the failure case for this action to trigger.