Ensure CI fails on non-prettier compliant PRs #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prado
added
the
status: ready for review
dternyak
reviewed
Jan 1, 2018
package.json
Outdated
| "prettier --write --config ./.prettierrc --list-different \"common/**/*.ts\"", | ||
| "prettier:diff-tsx": | ||
| "prettier --write --config ./.prettierrc --list-different \"common/**/*.tsx\"", | ||
| "prettier:diff": "npm run prettier:diff-ts && npm run prettier:diff-tsx", |
There was a problem hiding this comment.
We don't need both prettier:diff-tsx and prettier:diff-ts, a single regex should be able to accommodate both.
dternyak
reviewed
Jan 1, 2018
.travis.yml
Outdated
| @@ -20,6 +20,8 @@ install: | |||
|
|
|||
| jobs: | |||
| include: | |||
| - stage: Prettier Diff | |||
There was a problem hiding this comment.
Why run it in a different stage?
dternyak
reviewed
Jan 1, 2018
.travis.yml
Outdated
| @@ -20,6 +20,8 @@ install: | |||
|
|
|||
| jobs: | |||
| include: | |||
| - stage: Prettier Diff | |||
| script: npm run prettier:diff | |||
There was a problem hiding this comment.
To confirm, --list-different returns a non-zero exit code if there are any different files?
dternyak
changed the title
dternyak
changed the title
dternyak
approved these changes
Jan 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MyEtherWallet/MyEtherWallet#601