Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid chain id error #164

Merged
merged 3 commits into from
Nov 19, 2018
Merged

fix invalid chain id error #164

merged 3 commits into from
Nov 19, 2018

Conversation

kvhnuke
Copy link
Contributor

@kvhnuke kvhnuke commented Nov 19, 2018

Devop

  • Updated CHANGELOG.md
  • Add PR label

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #164 into develop will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
+ Coverage    19.12%   19.19%   +0.06%     
===========================================
  Files          345      346       +1     
  Lines         4355     4340      -15     
  Branches       580      575       -5     
===========================================
  Hits           833      833              
+ Misses        3242     3232      -10     
+ Partials       280      275       -5
Impacted Files Coverage Δ
...llets/web3-provider/methods/eth_sendTransaction.js 0% <0%> (ø) ⬆️
src/wallets/web3-provider/methods/utils.js 0% <0%> (ø)
...llets/web3-provider/methods/eth_signTransaction.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fece12...b890768. Read the comment docs.

@kvhnuke kvhnuke added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge Hotfix labels Nov 19, 2018
@gamalielhere gamalielhere merged commit 180bd17 into develop Nov 19, 2018
@gamalielhere gamalielhere deleted the hotfix/invalid-chainid branch November 19, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Hotfix Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants