Feature: add Satochip hardware wallet support #3494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/ilgon-technologies/ilgon-wallet into bug/aug
…Wallet into bug/aug
release/v5.7.22
This dist folder contains the files that will be served by github-pages
This folder contains the files for local access to MEW
Toporin
requested review from
andrewdahn,
gamalielhere,
gesseekur,
hsurf22,
kvhnuke and
rynst
as code owners
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed within 10 days if no further activity occurs. Thank you for your contributions. |
|
Closing because of inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Description
This is the initial pull request to integrate the Satochip hardware wallet to MyEtherWallet.
Satochip is an open-source hardware wallet based on a smartcard. Compared to the other hardware wallets on the market, Satochip has a few unique features:
Implementation details
For security reasons, smartcards cannot communicate directly with web applications running on a browser.
Communications between the Satochip smartcard and MEW is done through a bridge running locally on the user's computer (Satochip-Bridge). MEW sends transaction requests to the bridge via websocket on port 8397, the Bridge then forwards those requests to the smartcard and sends back the signed transactions.
More info
https://satochip.io (official website)
https://twitter.com/SatochipWallet (official Twitter account)
https://github.com/Toporin/ (official repository)
https://github.com/Toporin/SatochipApplet (satochip firmware repo)
https://github.com/Toporin/Satochip-Bridge (Satochip-Bridge repo)
https://pypi.org/project/pysatochip/ (pysatochip library)
https://t.me/Satochip (Telegram support)