This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Feature/disable generate on ipad #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gamalielhere
commented
Mar 15, 2018
•
gamalielhere
commented
- pop a modal when browser detects iphone or ipad
- disable input and generate button when iphone or ipad
kvhnuke
reviewed
Mar 19, 2018
| $scope.isMobileApple = function() { | ||
|
|
||
| if (/iPad|iPhone|iPod/.test(navigator.userAgent) && !window.MSStream) { | ||
| if (!!window.indexedDB || !!window.SpeechSynthesisUtterance || !!window.webkitAudioContext || |
There was a problem hiding this comment.
This is if condition is redundant, as it is returning true anyway
kvhnuke
reviewed
Mar 19, 2018
| } | ||
|
|
||
| if(globalFuncs.localStorage.getItem('awareAppleMobile') === null && $scope.isMobileApple()) { | ||
| $scope.appleMobileModal.open(); |
There was a problem hiding this comment.
I think it'll be better to open the modal when they click generate, otherwise users might think the whole website is not available for iPhone/ipad
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.