[CLEANUP] Final removal of deprecated functions #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegenberg
changed the title
Final removal of: - Document::getAllSelectors - Rule::setValues - Rule::getValues - DeclarationBlock::setSelector - DeclarationBlock::getSelector Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
remove-deprecated-functions
branch
from
13a459c
to
062a5b2
Compare
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
|
Thanks! 🙏 Please let's have separate PRs for this, one for each removed method, and including a changelog entry. This allows us reviewers to do the reviews more quickly, and we can revert the commit more easily in case we break something. |
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
|
I split the commit into several PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final removal of:
Document::getAllSelectorsRule::setValuesRule::getValuesDeclarationBlock::setSelectorDeclarationBlock::getSelectorSome tests probably need some fixing.