-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] Rector: Add strict return type based on returned strict expr type #581
[CLEANUP] Rector: Add strict return type based on returned strict expr type #581
Conversation
Rebased it. |
3a2cd41
to
beccff9
Compare
Should those PHPDoc |
I think so, if they don't provide anything more than the type hint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yes, please let's drop those redundant @return
PHPDoc annotations.
…r type This applies the rule ReturnTypeFromStrictBoolReturnExprRector. For Details see: https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#returntypefromstrictboolreturnexprrector Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
beccff9
to
94655b8
Compare
Rebased and removed the PHPDoc annotations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! 🙏
This applies the rule ReturnTypeFromStrictBoolReturnExprRector. For Details see:
https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#returntypefromstrictboolreturnexprrector