Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Remove Rule::getValues #582

Merged
merged 2 commits into from
Jun 19, 2024
Merged

[TASK] Remove Rule::getValues #582

merged 2 commits into from
Jun 19, 2024

Conversation

ziegenberg
Copy link
Contributor

Removing one function after another.

Supersedes #563

@ziegenberg
[TASK] Remove Rule::getValues
1f90f6a 
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
[TASK] Fix tests after removing Rule::getValues
dd2ee4d 
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg mentioned this pull request Jun 19, 2024
Closed
JakeQZ
JakeQZ approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for recovering it. Apologies for the mess-up <3

@JakeQZ JakeQZ added the removal A method, property, or some functionality has been removed. label Jun 19, 2024
@JakeQZ JakeQZ merged commit c415003 into MyIntervals:main Jun 19, 2024
18 checks passed
@ziegenberg ziegenberg deleted the remove-deprecated-rule-getvalues branch June 19, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@ziegenberg ziegenberg

Labels
removal A method, property, or some functionality has been removed.
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ziegenberg @JakeQZ