Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only replace 0. with . at the begin of a size value. #65

Merged
merged 5 commits into from
Aug 4, 2013

Conversation

yunosh
Copy link
Contributor

@yunosh yunosh commented Jul 19, 2013

This fixes values of "10.5" accidentally being converted to "1.5".

I would have added a unit test, but 50% of the test suite is currently failing, so there's not much use in those.

@sabberworm
Copy link
Contributor

Thanks for the pull requests. I’m thinking about removing the 0.. optimization entirely, I was never a big fan of that but didn’t have enough reasons to deny the pull request that added it (#57).
Actually, none of the unit tests should be failing. Could you provide me with an example of the output? I usually run the complete test suite whenever I create a new version tag. Thanks a lot!

@yunosh
Copy link
Contributor Author

yunosh commented Jul 19, 2013

The failed tests have been an intermittent issue, seems to work fine now, besides the changes introduced by my patch.

sabberworm added a commit that referenced this pull request Aug 4, 2013
Only replace 0. with . at the begin of a size value.
@sabberworm sabberworm merged commit 6698b77 into MyIntervals:master Aug 4, 2013
@yunosh yunosh deleted the fix-size-values branch August 5, 2013 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants