Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Officially add support for PHP 8.2 #1155

Closed
oliverklee opened this issue Jun 10, 2022 · 3 comments · Fixed by #1163
Closed

Officially add support for PHP 8.2 #1155

oliverklee opened this issue Jun 10, 2022 · 3 comments · Fixed by #1163
Labels
enhancement
Milestone
7.0.0

Comments

@oliverklee
Copy link
Contributor

oliverklee commented Jun 10, 2022 •
edited

We'll need to allow PHP 8.2 via composer.json as well.

@TimWolla Would you be willing to create a PR for this change (including the corresponding changelog entry)?
@oliverklee oliverklee added this to the 7.0.0 milestone Jun 10, 2022
@TimWolla
Copy link
Contributor

We'll need to allow PHP 8.1 via composer.json as well.

Did you mean 8.2? 8.1 is already listed:

emogrifier/composer.json

Line 40 in 6a1d61f

"php": "~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0",

@oliverklee oliverklee changed the title Officially add support for PHP 8.1 Officially add support for PHP 8.2 Jun 10, 2022
@oliverklee
Copy link
Contributor Author

Indeed I did. Fixed. Thanks!

@TimWolla
Copy link
Contributor

I would recommend waiting until the feature freeze (July, 19th) for this. It's still possible that new RFCs pass until then.

@TimWolla TimWolla mentioned this issue Jul 22, 2022
Merged
oliverklee pushed a commit that referenced this issue Jul 22, 2022
@TimWolla
[TASK] Add support for PHP 8.2 (#1163)
2046294 
Resolves #1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Add support for PHP 8.2 to composer.json
2 participants
@TimWolla @oliverklee