[FEATURE] Keep display:none elements with -emogrifier-keep
#737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The additional part of the XPath expression was obtained by running `:not(.-emogrifier-keep)` through `CssSelectorConverter::toXPath()`. It tests for attribute presence before checking the value, presumably as an omptimization to avoid unnecessary processing of a null/empty value. On the presumed basis that this is a good idea, a similar check has been added for the `style` attribute. Resolves #252.
oliverklee
reviewed
Sep 29, 2019
oliverklee
approved these changes
Sep 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional part of the XPath expression was obtained by running
:not(.-emogrifier-keep)throughCssSelectorConverter::toXPath(). It testsfor attribute presence before checking the value, presumably as an omptimization
to avoid unnecessary processing of a null/empty value. On the presumed basis
that this is a good idea, a similar check has been added for the
styleattribute.
Resolves #252.