Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to skip a phrase on a recording session. #52

Merged
merged 6 commits into from
Oct 14, 2021
Merged

Added feature to skip a phrase on a recording session. #52

merged 6 commits into from
Oct 14, 2021

Conversation

thorstenMueller
Copy link
Contributor

@thorstenMueller thorstenMueller commented Jul 8, 2021

Description

This PR for Mimic-Recording-Studio adds the functionality to skip recording currently shown phrase from the corpus without stopping recording session, editing corpus file and continue training as whished in #51.

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

Start Mimic-Recording-Studio and record and skip some phrases :-).

Documentation

When you are recording using web-ui you can now press "S" to skip recording that shown phrase. That keypress is in addition to existing keypresses ("R" and "Space").

What's happening when user hits "S"?

When pressing "S" key the web-ui will present the next phrase from the corpus. In the backend the SQLite column "prompt_num" (table: usermodel) will be increased on 1. This won't change any value which is used to calculate the average speech rate! No audio file is written in case of "S". If the user wants to clean the corpus file afterwards this can be done by taking a look to the new written text file (-skipped.txt) in the audio_files/uuid directory. Every skipped phrase will be saved there.

@thorstenMueller
Copy link
Contributor Author

Ooops. This latest merge was an error. I'll to roll it back.

Copy link
Collaborator

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is all working great, and a very nice feature!

A couple of tiny comments below.

backend/app/db.py Show resolved Hide resolved
frontend/src/App/Record.js Outdated Show resolved Hide resolved
backend/app/api.py Outdated Show resolved Hide resolved
backend/app/file_system.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants