Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on skip feature to Intro and Tutorial #68

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Add info on skip feature to Intro and Tutorial #68

merged 2 commits into from
Oct 27, 2021

Conversation

thorstenMueller
Copy link
Contributor

Description

In PR #52 i've added a feature to skip a phrase from the corpus. This PR adds the info on that feature to the docs shown in frontend.

Bildschirmfoto 2021-10-22 um 09 17 52

Bildschirmfoto 2021-10-22 um 09 18 03

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

Check "S" hint before recording start.

@thorstenMueller
Copy link
Contributor Author

Hi @krisgesling 👋 .
Do you think you can find some time to review/merge the PR during this week? But I don't want to rush you.

Copy link
Collaborator

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

The only thing I wanted to check is whether the SVG has any licensing or attribution requirements attached to it?

A minor thing I know, but also silly for us to ignore it and get burnt by something so small.

@thorstenMueller
Copy link
Contributor Author

Looks great, thanks.

The only thing I wanted to check is whether the SVG has any licensing or attribution requirements attached to it?

A minor thing I know, but also silly for us to ignore it and get burnt by something so small.

Good point @krisgesling. I created the svg myself using Inkscape and the existing "P" svg as template. So there shouldn't be any licensing trouble.

@krisgesling krisgesling merged commit 4cfef9c into MycroftAI:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants