Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple reloads at startup #1001

Closed
forslund opened this issue Aug 18, 2017 · 0 comments
Closed

Multiple reloads at startup #1001

forslund opened this issue Aug 18, 2017 · 0 comments
Labels
Type: Bug - complex

Comments

@forslund
Copy link
Collaborator

When skill service is loaded multiple reloads of all skills occur.

(mycroft) ake@roadrunner:~/projects/python/mycroft-core$ ./start.sh skills |& grep Reloading
2017-08-17 11:37:51,091 - Skills - DEBUG - Reloading Skill: skill-spelling
2017-08-17 11:37:53,222 - Skills - DEBUG - Reloading Skill: skill-spelling
2017-08-17 11:37:53,259 - Skills - DEBUG - Reloading Skill: skill-date-time
2017-08-17 11:37:53,351 - Skills - DEBUG - Reloading Skill: skill-ip
2017-08-17 11:37:53,368 - Skills - DEBUG - Reloading Skill: skill-singing
2017-08-17 11:37:55,423 - Skills - DEBUG - Reloading Skill: skill-date-time
2017-08-17 11:37:55,493 - Skills - DEBUG - Reloading Skill: skill-ip
2017-08-17 11:37:55,500 - Skills - DEBUG - Reloading Skill: skill-singing
2017-08-17 11:37:55,503 - Skills - DEBUG - Reloading Skill: skill-speak
2017-08-17 11:37:55,511 - Skills - DEBUG - Reloading Skill: skill-npr-news
2017-08-17 11:37:57,582 - Skills - DEBUG - Reloading Skill: skill-speak
2017-08-17 11:37:57,597 - Skills - DEBUG - Reloading Skill: skill-npr-news
2017-08-17 11:37:57,608 - Skills - DEBUG - Reloading Skill: skill-joke
2017-08-17 11:37:57,618 - Skills - DEBUG - Reloading Skill: skill-playback-control
2017-08-17 11:37:59,692 - Skills - DEBUG - Reloading Skill: skill-npr-news
2017-08-17 11:37:59,702 - Skills - DEBUG - Reloading Skill: skill-joke
2017-08-17 11:37:59,711 - Skills - DEBUG - Reloading Skill: skill-playback-control
2017-08-17 11:38:01,789 - Skills - DEBUG - Reloading Skill: skill-playback-control
2017-08-17 11:38:01,806 - Skills - DEBUG - Reloading Skill: rss_skill
2017-08-17 11:38:03,887 - Skills - DEBUG - Reloading Skill: skill-playback-control
2017-08-17 11:38:03,898 - Skills - DEBUG - Reloading Skill: rss_skill
2017-08-17 11:38:03,910 - Skills - DEBUG - Reloading Skill: skill-desktop-launcher
2017-08-17 11:38:03,924 - Skills - DEBUG - Reloading Skill: skill-volume
2017-08-17 11:38:06,012 - Skills - DEBUG - Reloading Skill: rss_skill
2017-08-17 11:38:06,023 - Skills - DEBUG - Reloading Skill: skill-desktop-launcher
2017-08-17 11:38:06,052 - Skills - DEBUG - Reloading Skill: skill-volume
2017-08-17 11:38:06,071 - Skills - DEBUG - Reloading Skill: skill-naptime
2017-08-17 11:38:06,093 - Skills - DEBUG - Reloading Skill: skill-installer
2017-08-17 11:38:08,193 - Skills - DEBUG - Reloading Skill: skill-naptime
2017-08-17 11:38:08,200 - Skills - DEBUG - Reloading Skill: skill-installer
2017-08-17 11:38:08,207 - Skills - DEBUG - Reloading Skill: skill-pairing
2017-08-17 11:38:08,214 - Skills - DEBUG - Reloading Skill: skill-wiki
2017-08-17 11:38:10,281 - Skills - DEBUG - Reloading Skill: skill-pairing
2017-08-17 11:38:10,289 - Skills - DEBUG - Reloading Skill: skill-wiki
2017-08-17 11:38:10,302 - Skills - DEBUG - Reloading Skill: skill-weather
2017-08-17 11:38:10,333 - Skills - DEBUG - Reloading Skill: skill-mark1-demo
2017-08-17 11:38:12,414 - Skills - DEBUG - Reloading Skill: skill-wiki
2017-08-17 11:38:12,423 - Skills - DEBUG - Reloading Skill: skill-weather
2017-08-17 11:38:12,517 - Skills - DEBUG - Reloading Skill: skill-mark1-demo
2017-08-17 11:38:12,526 - Skills - DEBUG - Reloading Skill: skill-hello-world
2017-08-17 11:38:12,532 - Skills - DEBUG - Reloading Skill: fallback-wolfram-alpha
2017-08-17 11:38:12,556 - Skills - DEBUG - Reloading Skill: skill-configuration
2017-08-17 11:38:14,632 - Skills - DEBUG - Reloading Skill: skill-mark1-demo
2017-08-17 11:38:14,637 - Skills - DEBUG - Reloading Skill: skill-hello-world
2017-08-17 11:38:14,647 - Skills - DEBUG - Reloading Skill: fallback-wolfram-alpha
2017-08-17 11:38:14,652 - Skills - DEBUG - Reloading Skill: skill-configuration
2017-08-17 11:38:14,662 - Skills - DEBUG - Reloading Skill: skill-stop
2017-08-17 11:38:14,668 - Skills - DEBUG - Reloading Skill: skill-reminder
2017-08-17 11:38:16,736 - Skills - DEBUG - Reloading Skill: skill-configuration
2017-08-17 11:38:16,744 - Skills - DEBUG - Reloading Skill: skill-stop
2017-08-17 11:38:16,753 - Skills - DEBUG - Reloading Skill: skill-reminder
2017-08-17 11:38:16,775 - Skills - DEBUG - Reloading Skill: skill-alarm
2017-08-17 11:38:16,816 - Skills - DEBUG - Reloading Skill: skill-stock
2017-08-17 11:38:16,827 - Skills - DEBUG - Reloading Skill: skill-personal
2017-08-17 11:38:18,870 - Skills - DEBUG - Reloading Skill: skill-reminder
2017-08-17 11:38:18,900 - Skills - DEBUG - Reloading Skill: skill-alarm
2017-08-17 11:38:18,933 - Skills - DEBUG - Reloading Skill: skill-stock
2017-08-17 11:38:18,940 - Skills - DEBUG - Reloading Skill: skill-personal
2017-08-17 11:38:18,962 - Skills - DEBUG - Reloading Skill: skill-audio-record
2017-08-17 11:38:21,040 - Skills - DEBUG - Reloading Skill: skill-personal
2017-08-17 11:38:21,050 - Skills - DEBUG - Reloading Skill: skill-audio-record
2017-08-17 11:38:23,133 - Skills - DEBUG - Reloading Skill: skill-audio-record
forslund added a commit to forslund/mycroft-core that referenced this issue Aug 18, 2017
@forslund
Fix multiple reloads of skills at startup
e75c1ec 
==== Fixed Issues ====
MycroftAI#1001

====  Tech Notes ====
Previously the skills were reloaded a couple of times during startup
since updates of the .pyc file and possible the settings.json file were
made.

This commit adds a bit finer control over which files to check.
Currently all files in skill root except ones ending in .pyc and the
settings.json are checked along with all visible subdirectories
@forslund forslund mentioned this issue Aug 18, 2017
Merged
forslund added a commit to forslund/mycroft-core that referenced this issue Aug 18, 2017
@forslund
Fix multiple reloads of skills at startup
70bd15a 
==== Fixed Issues ====
MycroftAI#1001

====  Tech Notes ====
Previously the skills were reloaded a couple of times during startup
since updates of the .pyc file and possible the settings.json file were
made.

This commit adds a bit finer control over which files to check.
Currently all files in skill root except ones ending in .pyc and the
settings.json are checked along with all visible subdirectories
forslund added a commit to forslund/mycroft-core that referenced this issue Aug 18, 2017
@forslund
Fix multiple reloads of skills at startup
eb4991a 
==== Fixed Issues ====
MycroftAI#1001

====  Tech Notes ====
Previously the skills were reloaded a couple of times during startup
since updates of the .pyc file and possible the settings.json file were
made.

This commit adds a bit finer control over which files to check.
Currently all files in skill root except ones ending in .pyc and the
settings.json are checked along with all visible subdirectories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug - complex
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forslund @augustnmonteiro