Fix multiple reloads of skills at startup #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
force-pushed
the
bugfix/issue-1001
branch
from
e75c1ec
to
70bd15a
Compare
|
Please test carefully. I didn't find any cases where it failed to reload an updated skill but I may have missed something. |
==== Fixed Issues ==== MycroftAI#1001 ==== Tech Notes ==== Previously the skills were reloaded a couple of times during startup since updates of the .pyc file and possible the settings.json file were made. This commit adds a bit finer control over which files to check. Currently all files in skill root except ones ending in .pyc and the settings.json are checked along with all visible subdirectories
forslund
force-pushed
the
bugfix/issue-1001
branch
from
70bd15a
to
eb4991a
Compare
forslund
added
the
CLA: Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==== Fixed Issues ====
#1001
==== Tech Notes ====
Previously the skills were reloaded a couple of times during startup
since updates of the .pyc file and possible the settings.json file were
made.
This commit adds a bit finer control over which files to check.
Currently all files in skill root except ones ending in .pyc and the
settings.json are checked along with all visible subdirectories