Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli client console script broken #1036

Closed
MatthewScholefield opened this issue Aug 31, 2017 · 2 comments
Closed

Cli client console script broken #1036

MatthewScholefield opened this issue Aug 31, 2017 · 2 comments
Labels
Type: Bug - complex

Comments

@MatthewScholefield
Copy link
Contributor

MatthewScholefield commented Aug 31, 2017 •
edited
Loading

In mycroft/client/text/main.py, the if __name__ == '__main__': contents need to be moved inside def main() so that the only thing called is main(). This is because, the console script doesn't call the file; it calls the mycroft.client.text.main:main.
penrods pushed a commit that referenced this issue Aug 31, 2017
Correcting CLI handling of main() for issue #1036
b99ddc6 
The idiom for handling main() was incorrect to allow the CLI
to be invoked by the mycroft-cli-clent script.

==== Fixed Issues ====
@penrods penrods mentioned this issue Aug 31, 2017
Merged
MatthewScholefield pushed a commit that referenced this issue Aug 31, 2017
@MatthewScholefield
Correcting CLI handling of main() for issue #1036
ae25836 
The idiom for handling main() was incorrect to allow the CLI
to be invoked by the mycroft-cli-clent script.

==== Fixed Issues ====
@LearnedVector
Copy link
Contributor

@MatthewScholefield can this be closed now?

@MatthewScholefield
Copy link
Contributor Author

MatthewScholefield commented Aug 31, 2017 •
edited
Loading

Yep, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug - complex
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatthewScholefield @LearnedVector