Minor CLI enhancements, mycroft-cli-client fix #1036 #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2017 18:05
Several changes to CLI behavior, all minor: * Inverted the behavior or PgUp/PgDn. I think it was just wrong * Added "oldest" and "newest" indicators to the log listing to simplify finding your way inside the logs * Added support for _not_ scrolling when in the middle of the log output. It will now only auto-scroll when already at the front of the log so you keep seeing new messages automatically. * Added a heading for the mic output level * Limited the mic output level to just the size of the bottom area (previously it was proportional to the screen height) * FIX: Changed the default filter string for viseme * FIX: The saving of settings was broken * Ran autopep8 which added a few bits of whitespace here and there
The idiom for handling main() was incorrect to allow the CLI to be invoked by the mycroft-cli-clent script. ==== Fixed Issues ====
penrods
added
CLA: Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes to CLI behavior, all minor:
simplify finding your way inside the logs
output. It will now only auto-scroll when already at the front
of the log so you keep seeing new messages automatically.
area (previously it was proportional to the screen height)
==== Fixed Issues ====
#1036
The idiom for handling main() was incorrect to allow the CLI
to be invoked by the mycroft-cli-clent script.