Fix hash method to work with python3 #1443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python3, unicode objects have to be encoded before being hashed with hashlib so this commit fixes the hash method so it works with both python2 and python3.
|
Hi @antlarr, thanks for the PR. We've prepared a bunch of fixes for python 3 in the 18.02 branch. Can you check that the issue remains in there? and in that case resubmit for that branch? |
|
Ah, I noticed the python3 branch (which is very old) but not that 18.02 branch. When is it planned to be merged to dev ? |
|
Btw, the issue is fixed in the 18.02 branch. Great. Althought for python3 to work, the skillls need also to support python3 with fixes such as MycroftAI/fallback-wolfram-alpha#11 |
|
Yes, before 18.02 we have officially supported Python 2.7 only. With 18.02 we are jumping to Python 3 for mycroft-core. And yep, as a result we will need to update several skills that fall under our control. Thanks for verifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In python3, unicode objects have to be encoded before being
hashed with hashlib so this commit fixes the hash method so
it works with both python2 and python3.
How to test
I run mycroft-core with python3 and saw an exception being raised:
TypeError: Unicode-objects must be encoded before hashing
After applying this commit, it works successfully.
Contributor license agreement signed?
CLA [yes] (Whether you have signed a CLA - Contributor Licensing Agreement