Make the combo lock handle multiple users #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
Type: Bug - complex
CLA: Yes
|
Hello @forslund! Thanks for submitting the PR.
|
On the Mark-1 the locking would fail since the first time the lock is accessed the process is run under root (script checking the enclosure version). This caused the locking to fail since the normal mycroft processes got an access error (lock-file owned by root) This change creates lock-files and sets the permissions to 0o777 if the file doesn't exist so it's accessible for all users
forslund
force-pushed
the
bugfix/mark-1-locking
branch
from
5a6f32e
to
05e885f
Compare
forslund
changed the title
|
Hold on on this one a bit longer, I'm rechecking some things. (It suddently stopped working again) |
|
False alarm, it was my half done pulse changes that made the skill loading halt when getting to the volume control |
|
I'm assuming Codacy is stuck on something else. I'm ignoring the "Pending". |
Add Apache license header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the Mark-1 the locking would fail since the first time the lock is
accessed the process is run under root (script checking the enclosure
version). This caused the locking to fail since the normal mycroft
processes got an access error (lock-file owned by root)
This change creates lock-files and sets the permissions to
0o777if the file doesn't exist so it's accessible for all users
How to test
Install the change on a mark-1, reboot and verify that all the processes starts correctly.
Contributor license agreement signed?
CLA [Yes]