Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Change regex string to raw string in remote_tts #1845

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

mpolidori
Copy link
Contributor

Description

Fix for issue #1844

Contributor license agreement signed?

CLA [signed]

@pep8speaks
Copy link

Hello @mpolidori! Thanks for submitting the PR.

@penrods penrods added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Oct 10, 2018
Copy link
Contributor

@penrods penrods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@penrods
Copy link
Contributor

penrods commented Oct 10, 2018

Codacy seems to be stuck, but I'm going to merge anyway. Adding the raw string prefix is simple and safe.

@penrods penrods merged commit a43a748 into MycroftAI:dev Oct 10, 2018
@mpolidori
Copy link
Contributor Author

Great. This is my first actual pull request. I wasn't sure why it was stuck. I thought maybe I missed something. I have a lot to learn.

@forslund
Copy link
Collaborator

Seems like you did everything right, the codacy bot get stuck at times.

Many thanks for contributing your time and your code!

@mpolidori mpolidori deleted the patch-1 branch October 10, 2018 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants