This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Send skill page info for all skills #2052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
the
CLA: Yes
forslund
requested review from
matheuslima,
MatthewScholefield and
chrisveilleux
forslund
added
the
Merge after next release
forslund
force-pushed
the
feature/push-meta-for-all-skills
branch
from
0fde14c
to
f8ba77a
Compare
- Create BLANK template for skills without settingsmeta.json - Add title and icon from msm entry to all settingsmeta uploads
This excludes padatious from the list of skills to upload
forslund
force-pushed
the
feature/push-meta-for-all-skills
branch
from
f8ba77a
to
7fa1adf
Compare
|
The production backend is still populated by the empty skills so I think it's better to hold off on this one still. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Requires msm PR #33 and an update for Tartarus to accept the the "icon_img" entry.
How to test
Check that Mycroft starts and that the skill page gets populated with a bunch of blank skill entries.
Contributor license agreement signed?
CLA [ Yes ]