Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/skill gid #2104

Merged
merged 10 commits into from May 22, 2019
Merged

Feature/skill gid #2104

merged 10 commits into from May 22, 2019

Commits on May 18, 2019

  1. Re-add support for skill_gid in settingsmeta upload

    @forslund
    forslund committed May 18, 2019
    Copy the full SHA
    56ed5a6 View commit details
    Browse the repository at this point in the history

  2. Remove BLANK boilerplate content

    @forslund
    forslund committed May 18, 2019
    Copy the full SHA
    693bf2c View commit details
    Browse the repository at this point in the history

  3. Replace hashed meta with skill_gid as identifier 

    This also removes the notion of an owner skill and all skills may update settings on the server.
    @forslund
    forslund committed May 18, 2019
    Copy the full SHA
    f6347ae View commit details
    Browse the repository at this point in the history

  4. Switch endpoint for fetching settings 

    use the userSkill endpoint instead of skill endpoint to always be able
to get settings no matter who the owner is.
    @forslund
    forslund committed May 18, 2019
    Copy the full SHA
    93a0b31 View commit details
    Browse the repository at this point in the history

  5. Check both endpoints for settings

    @forslund
    forslund committed May 18, 2019
    Copy the full SHA
    4a75526 View commit details
    Browse the repository at this point in the history

  6. Delete remote settings before pushing 

    - restore storing / loading uuid
- use uuid to delete before pushing settingsmeta
    @forslund
    forslund committed May 18, 2019
    Copy the full SHA
    6eb2aef View commit details
    Browse the repository at this point in the history

  7. Add safety around skillMetadata 

    skillMetadata could be accessed in settings without it when checking if remote update was needed.
    @forslund
    forslund committed May 18, 2019
    Copy the full SHA
    4518a11 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Switch to getting skill_gid from msm skill entry

    @forslund
    forslund committed May 21, 2019
    Copy the full SHA
    2208ee1 View commit details
    Browse the repository at this point in the history

  2. Remove the delete metadata calls when updating settings 

    The calls are not implemented and functionality will likely change.
    @forslund
    forslund committed May 21, 2019
    Copy the full SHA
    c3ac9d8 View commit details
    Browse the repository at this point in the history

  3. Finalize skill_gid in skills manifest. 

    Before sending the skills manifest to the backend attach device uuid as needed.
    @forslund
    forslund committed May 21, 2019
    Copy the full SHA
    716c16a View commit details
    Browse the repository at this point in the history