This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Voight kampff config given #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
reviewed
May 18, 2020
krisgesling
reviewed
May 18, 2020
forslund
force-pushed
the
feature/voight-kampff-config
branch
from
14a632e
to
9a81e32
Compare
Adds the "Given the user's {config} is {value}" step implementation
This will patch the configuration with a section from a dictionary that
can either be a global (shipped in
mycroft/res/{lang}/configurations.json) or shipped with the test
definition. The file should be named the same as the feature file but
instead of ".feature" the extension should be ".config.json".
mycroft/res/text/en-us/configurations.json contains a couple of
pre-defined configurations that can be applied
- units (metric/imperial)
- location (Stockholm)
After each scenario any applied patch will be cleared
- Copyright year - typo
forslund
force-pushed
the
feature/voight-kampff-config
branch
from
9a81e32
to
e08f630
Compare
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
May 19, 2020
|
Please add this information on the mycroft guide in the test section. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
Given the user's {config} is {value}step implementationThis will patch the configuration with a section from a dictionary that
can either be a global (shipped in
mycroft/res/{lang}/configurations.json) or shipped with the testdefinition. The file should be named the same as the feature file but
instead of
.featurethe extension should be.config.json.mycroft/res/text/en-us/configurations.jsoncontains a couple ofpre-defined configurations that can be applied
After each scenario any applied patch will be cleared
In addition this PR adds the message configuration.patch.clear to clear an applied patch.
If this is approach is good enough it resolves #2547.
How to test
Contributor license agreement signed?
CLA [ Yes ]