-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve help message and logging of dev_setup.sh #3105
Conversation
Voight Kampff Integration Test Succeeded (Results) |
Looks like a nice improvement. I think the github action is running into an issue when the log folder hasn't been created and given the correct permissions. Maybe move that stage to the start of the setup? |
Checked locally, should be ok this time. |
Codecov Report
@@ Coverage Diff @@
## dev #3105 +/- ##
==========================================
- Coverage 54.05% 54.04% -0.01%
==========================================
Files 120 120
Lines 11032 11032
==========================================
- Hits 5963 5962 -1
- Misses 5069 5070 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes looks good now and the CI is happy. Do you think it would be a good idea to add a "setup complete" line at the end to explicitly show that the dev-setup completed successfully?
Probably not a bad idea. We can also explicitly call out that the new logfile exists and may have further information. Should I include that in this PR? |
I think it's a good idea @krisgesling do you have any opinion? |
I went ahead and added it in. |
Hey sorry, I was away last week but this looks great. Agree on the final success message too 👍 My only question is whether we need to use the |
Thanks @krisgesling , good call-out. I'll be sure to have a better test setup next time. I've submitted that fix. |
@forslund Anything else you'd like me to do on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike this is all working great now!
Description
Corrects incidental findings from review of dev_setup.sh (fixes #1714). Most of the findings have been corrected already. This PR should close what little remains, aside from a security concern with log file permissions that probably belongs in a separate issue.
How to test
Execute dev_setup.sh in various operating systems
Execute
shellcheck dev_setup.sh
for linting and best practicesContributor license agreement signed?
CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement