This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Issues 76 - Fix changes to wikipedia skill so that tests pass #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' in wiki vocab file'
|
@ethanaward please coordinate with @jdorleans to see why the tests aren't working on this PR. |
ryanleesipes
added
the
Type: Enhancement - proposed
|
I thought I had commented on this PR a few days ago. Have you guys created another PR for this task? |
|
Yeah, this is a different (clean) PR. |
|
Ok, the changes seems reasonable, but before merging I'd like to know if anyone has tested it. |
|
I tested it using ./start.sh unittest on my own, and the tests passed. @ryanleesipes was wondering why the tests weren't showing here, though. |
|
ok, this seems to be a forked branch which means it does not exist into our repo. As a result, Travis won't be able to find it and run the tests |
Closed
NeonDaniel
pushed a commit
to NeonDaniel/mycroft-core
that referenced
this pull request
Jun 8, 2022
* feat/fallback_stt * add vosk * license tests * add stt unittests * add stt unittests * test default plugins * add fallback stt unittests * disable py3.10 unittests temporarily build tests will still fail for py3.10, once they pass reenable py3.10 unittests * test bad fallback stt configs Co-authored-by: jarbasai <jarbasai@mailfence.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the wikipedia skill so that it triggers on 'what does wikipedia say about'. I also removed 'who is' and 'who was' in the vocab, as those will be handled by Wolfram.