Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback to HA conversation is never used #23

Closed
andlo opened this issue Feb 8, 2020 · 2 comments
Closed

fallback to HA conversation is never used #23

andlo opened this issue Feb 8, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@andlo
Copy link
Collaborator

andlo commented Feb 8, 2020

It seems like the fallback to Homeassistant conversation is never used.

it seems that nomatter if “enable_fallback”: true the skill still thinks it is false.

In lines 59..61 is the problem.

                if conversation_activated:
                    self.enable_fallback = \
                        self.settings.get('enable_fallback') == 'true'

should be

                if conversation_activated:
                    self.enable_fallback = \
                        self.settings.get('enable_fallback')

Then it works.

I made a fix in the fix_fallback branch and will PR that to the default if/when someone confirms it is working for them too.

@andlo andlo added the bug Something isn't working label Feb 8, 2020
@sup08228
Copy link

I confirm that this has fixed the issue. It is correctly falling back. Thanks andlo!!

@andlo
Copy link
Collaborator Author

andlo commented Feb 11, 2020

@krisgesling mentioned that due to changes in settingsmeta.json we should waite a bit until merging....

@andlo andlo mentioned this issue Mar 1, 2020
3 tasks
Tony763 referenced this issue in Tony763/skill-homeassistant Aug 22, 2020
Tony763 referenced this issue in Tony763/skill-homeassistant Aug 22, 2020
Tony763 referenced this issue in Tony763/skill-homeassistant Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants