We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems like the fallback to Homeassistant conversation is never used.
it seems that nomatter if “enable_fallback”: true the skill still thinks it is false.
“enable_fallback”: true
In lines 59..61 is the problem.
if conversation_activated: self.enable_fallback = \ self.settings.get('enable_fallback') == 'true'
should be
if conversation_activated: self.enable_fallback = \ self.settings.get('enable_fallback')
Then it works.
I made a fix in the fix_fallback branch and will PR that to the default if/when someone confirms it is working for them too.
The text was updated successfully, but these errors were encountered:
I confirm that this has fixed the issue. It is correctly falling back. Thanks andlo!!
Sorry, something went wrong.
@krisgesling mentioned that due to changes in settingsmeta.json we should waite a bit until merging....
5e4ea6a
Fix #23 fallback never used
dd8a060
df28337
318abfe
No branches or pull requests
It seems like the fallback to Homeassistant conversation is never used.
it seems that nomatter if
“enable_fallback”: true
the skill still thinks it is false.In lines 59..61 is the problem.
should be
Then it works.
I made a fix in the fix_fallback branch and will PR that to the default if/when someone confirms it is working for them too.
The text was updated successfully, but these errors were encountered: