Move #core Skills out of DEFAULT and into each DEFAULT.platform file,… #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KathyReid
added
approved
|
One thing that I think might be needed here is a DEFAULT.linux file for linux- or git-based installs. I don't know how to implement that though. Very happy to take pointers. |
|
Are there a reasons you decided not to include the first three defaults in the various specific platforms? Is the verbal volume control not useful even on those platforms, for example? |
|
@penrods good pickup, that wasn't a conscious decision, that was poor attention to detail. |
add mycroft-playback-control mycroft-speak mycroft-volume
add mycroft-playback-control mycroft-speak mycroft-volume
add mycroft-playback-control mycroft-speak mycroft-volume
Add common Skills back into DEFAULT-SKILLS as per Skill Team Mtg 19th July
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on discussions w/ @el-tocino, @AIIX and @penrods around the need to slightly modify the DEFAULT file so that it doesn't overwrite Skills that are customised on a per-platform basis, like
skill-wikiis for the KDE platform.This is a really simple change and should be non-breaking, but definitely needs an experienced eye to review because of the large scope that the DEFAULT.* files have.
Suggested test sequence to validate this PR:
Using the KDE enclosure, remove all Skills. Run
msm defaultto bring in default Skills.Ensure that the offending Skills (stocks, weather - sorry I couldn't find the wikipedia Skill in the #core list) are not installed.
This tests the intended outcome for KDE
Using the Mark 1 enclosure, remove all Skills. Run
msm defaultto bring in default Skills.Ensure that all the default Skills are loaded.
This tests that we don't adversely impact other Skills with the change