Change Time UI layouts for horizontal mode and vertical mode and fix margins #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Is there an easy way to align the hours to the right when it's only a single character? eg 9:31 rather than 12:31 |
This has been fixed, and all 0:1 and 0:00 and 00:00 has been taken into account, currently the skill seems configured to send 00:00 format but now any of the formats should be working as spec |
|
Awesome, thanks for all this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes margins and auto changes layout responsively as suggested by @dschweppe on #92 to have time side by side in horizontal display and maintains vertical layout for vertical display
Preview - Width: 800 Height: 480 [horizontal]
Preview - Width: 480 Height: 800 [vertical]
