Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fail the request if objects are pruned for object and balance change #11476

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

patrickkuo
Copy link
Contributor

@patrickkuo patrickkuo commented Apr 28, 2023

Description

as titled.

Tested on testnet:

request

{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "sui_getTransactionBlock",
  "params": ["Cgww1sn7XViCPSdDcAPmVcARueWuexJ8af8zD842Ff43", {"showBalanceChanges": true, "showObjectChanges":true}]
}

response:

{
    "jsonrpc": "2.0",
    "result": {
        "digest": "Cgww1sn7XViCPSdDcAPmVcARueWuexJ8af8zD842Ff43",
        "timestampMs": "1679936400000",
        "checkpoint": "0",
        "errors": [
            "Cannot retrieve balance changes: Error checking transaction input objects: ObjectNotFound { object_id: 0x0000000000000000000000000000000000000000000000000000000000000002, version: Some(SequenceNumber(1)) }",
            "Cannot retrieve object changes: Error checking transaction input objects: ObjectNotFound { object_id: 0x0000000000000000000000000000000000000000000000000000000000000002, version: Some(SequenceNumber(1)) }"
        ]
    },
    "id": 1
}

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Apr 28, 2023 9:14pm
explorer-storybook ⬜️ Ignored (Inspect) Apr 28, 2023 9:14pm
sui-wallet-kit ⬜️ Ignored (Inspect) Apr 28, 2023 9:14pm
wallet-adapter ⬜️ Ignored (Inspect) Apr 28, 2023 9:14pm

@patrickkuo patrickkuo enabled auto-merge (squash) April 28, 2023 21:23
@patrickkuo patrickkuo merged commit deb8d58 into main Apr 28, 2023
@patrickkuo patrickkuo deleted the pat/balance_change_do_not_fail_when_object_not_found branch April 28, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants