[move-compiler] Add public struct type support to the parser #13917
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tzakian
force-pushed
the
tzakian/public-struct
branch
from
d19e521
to
f955406
Compare
tzakian
requested review from
a team,
oxade,
amnn,
wlmyng,
bmwill,
longbowlu,
mystenmark,
gegaowp,
Jordan-Mysten,
lanvidr,
stefan-mysten,
randall-Mysten,
ronny-mysten and
joyqvq
as code owners
tzakian
requested review from
pchrysochoidis
and removed request for
a team
github-actions
bot
added
the
Type: Documentation
tzakian
force-pushed
the
tzakian/postfix-abilities
branch
from
9beb78a
to
4c88acd
Compare
tzakian
removed request for
oxade,
amnn,
wlmyng,
bmwill,
longbowlu and
mystenmark
github-actions
bot
removed
the
Type: Documentation
There was a problem hiding this comment.
To my knowledge this is the first backwards incompatible change, so we need to split off a separate version of the move-stdlib that tracks the new 2024 edition as well.
It is indeed neat to do so, but we don't have to split it off, and it might be worth not doing so to make sure we aren't breaking the compiler. Thoughts?
We would just need to change the tests to stick the stdlib stuff in its own package with its own package config settings
| false | ||
| } else { | ||
| true |
| let current_package = context.package_name; | ||
| match visibility { |
There was a problem hiding this comment.
Nit, maybe check the feature gate at the top level here, as I think this is a bit strange as is
There was a problem hiding this comment.
My thinking behind this was to only mention the feature gate if there's a public struct but not if, e.g., someone wrote public(package) struct or something like that. But, happy to move it up to the top level as well :)
| @@ -0,0 +1,10 @@ | |||
| [package] | |||
There was a problem hiding this comment.
Ah, neat! This should be fun :)
tzakian
force-pushed
the
tzakian/postfix-abilities
branch
from
4c88acd
to
29dbd51
Compare
I like this idea! Let me see about updating it so we compile the stdlib in legacy mode. |
tzakian
force-pushed
the
tzakian/postfix-abilities
branch
from
29dbd51
to
b435686
Compare
tzakian
force-pushed
the
tzakian/public-struct
branch
from
75a55b0
to
240ce6c
Compare
tzakian
force-pushed
the
tzakian/public-struct
branch
from
240ce6c
to
04a496a
Compare
tzakian
force-pushed
the
tzakian/public-struct
branch
from
04a496a
to
930032c
Compare
tzakian
force-pushed
the
tzakian/public-struct
branch
from
930032c
to
989e664
Compare
tzakian
force-pushed
the
tzakian/public-struct
branch
from
989e664
to
292b03b
Compare
Description
Add support for
public structdeclarations in the Move 2024 edition.To my knowledge this is the first backwards incompatible change, so we need to split off a separate version of the move-stdlib that tracks the new 2024 edition as well.
The bottom commit of this PR does this, and also refactors the test runner so we aren't passing so many fields all the time in the test runner.
Test Plan
Added additional tests.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Adds initial
public structtype visibility support to Move 2024.alpha. When using the Move 2024.alpha edition you will be required to writepublicin front of the struct type which will keep the same semantics asstructwith no visibility modifiers today (i.e., in thelegacyedition), this is to allow for future support of private struct types.