[GraphQL] fix issue with failed dry run and add more e2e test #16248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmazzz
requested review from
amnn,
wlmyng,
stefan-mysten and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
| results | ||
| .into_iter() | ||
| .map(DryRunEffect::try_from) | ||
| .collect::<Result<Vec<_>, Error>>()?, |
There was a problem hiding this comment.
Will this return an error in case DryRun fails?
There was a problem hiding this comment.
When a dry run fails, dev_inspect_results.results would be None and dev_inspect_results.error would be Some. If the dry run succeeds, then the reverse is true. Here we are in the branch where the dry run succeeds and results is Some. And to clarify, the Error in collect::<Result<Vec<_>, Error>>()? is potential internal errors from DryRunEffect::try_from.
amnn
approved these changes
Feb 15, 2024
wlmyng
approved these changes
Feb 15, 2024
emmazzz
force-pushed
the
emma/fix-dry-run
branch
from
80ff458
to
557f134
Compare
cgswords
pushed a commit
that referenced
this pull request
Feb 24, 2024
## Description Currently we assume that the dev inspect result coming from fullnode is always `Some` but it can actually be `None` if the transaction failed to execute. This PR fixes that and adds a few more e2e test cases for this scenario as well as a scenario where a `TransactionKind` is provided. ## Test Plan Added tests --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
emmazzz
added a commit
that referenced
this pull request
Feb 28, 2024
## Description Currently we assume that the dev inspect result coming from fullnode is always `Some` but it can actually be `None` if the transaction failed to execute. This PR fixes that and adds a few more e2e test cases for this scenario as well as a scenario where a `TransactionKind` is provided. ## Test Plan Added tests --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we assume that the dev inspect result coming from fullnode is always
Somebut it can actually beNoneif the transaction failed to execute. This PR fixes that and adds a few more e2e test cases for this scenario as well as a scenario where aTransactionKindis provided.Test Plan
Added tests
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes