[governance] add delegation staking pool implementation #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmazzz
requested review from
lxfind,
damirka,
tnowacki,
punwai,
sblackshear and
longbowlu
damirka
reviewed
Aug 31, 2022
damirka
reviewed
Aug 31, 2022
damirka
reviewed
Aug 31, 2022
| /// the pool tokens until they activate the delegation on or after the `earliest_activation_epoch`. | ||
| public(friend) fun request_add_delegation(pool: &mut StakingPool, stake: Balance<SUI>, sui_token_lock: Option<EpochTimeLock>, ctx: &mut TxContext) { | ||
| assert!(balance::value(&stake) > 0, 0); | ||
| let delegation = Delegation { |
There was a problem hiding this comment.
Is it possible for user to have 2 Delegations for the same validator?
There was a problem hiding this comment.
Yes. Or more than 2.
damirka
reviewed
Aug 31, 2022
damirka
reviewed
Aug 31, 2022
damirka
reviewed
Aug 31, 2022
damirka
reviewed
Aug 31, 2022
emmazzz
force-pushed
the
pool
branch
3 times, most recently
from
ec6d212
to
3fc4da3
Compare
lxfind
reviewed
Sep 19, 2022
emmazzz
force-pushed
the
pool
branch
3 times, most recently
from
e6ae577
to
9307f51
Compare
lxfind
reviewed
Sep 19, 2022
lxfind
approved these changes
Sep 19, 2022
emmazzz
changed the title
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR adds a delegation staking pool implementation and connects it with other modules:
staking_poolmodule is added. Pool tokens are distributed to users at epoch boundaries after rewards are added to the pool.delegationmodule andepoch_reward_recordmodule are removed as they are no longer relevant.