[governance] add validator onboarding epoch #3804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation reward claiming
emmazzz
commented
Aug 10, 2022
| @@ -160,10 +160,6 @@ module sui::validator_set { | |||
| let validator_index = option::extract(&mut validator_index_opt); | |||
| let validator = vector::borrow_mut(&mut self.active_validators, validator_index); | |||
| validator::request_remove_delegation(validator, delegate_amount); | |||
| } else { | |||
| // TODO: How do we deal with undelegating from inactive validators? | |||
There was a problem hiding this comment.
No special action needed here anymore after the changes in this PR.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Same functionality implemented in #4187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a validator's onboarding epoch to the validator struct and the epoch reward record, as well as corresponding checks in
delegation::can_claim_rewards. This fixes a bug we have that permits a delegator to claim rewards for epoch that they didn't delegate to and also completes the validator removal story for now.